Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 Text Block #181 #255

Merged
merged 3 commits into from
Nov 16, 2023
Merged

V2 Text Block #181 #255

merged 3 commits into from
Nov 16, 2023

Conversation

Lakshmishri
Copy link
Collaborator

@Lakshmishri Lakshmishri commented Nov 15, 2023

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #181

Test URLs:

Copy link
Contributor

aem-code-sync bot commented Nov 15, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

Copy link
Contributor

aem-code-sync bot commented Nov 15, 2023

Page Scores Audits Google
/drafts/lakshmi/text PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

styles/styles.css Outdated Show resolved Hide resolved
Copy link
Contributor

aem-code-sync bot commented Nov 15, 2023

Page Scores Audits Google
/drafts/lakshmi/text PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@Lakshmishri Lakshmishri requested a review from cogniSyb November 15, 2023 15:40
@taimurCognizant
Copy link
Collaborator

image @Lakshmishri I see some padding around the section for this components. But in design there aren't any image @cogniSyb Although it look better with section padding but want to confirm if this is expected or not

@cogniSyb
Copy link
Collaborator

@Lakshmishri I see some padding around the section for this components. But in design there aren't any @cogniSyb Although it look better with section padding but want to confirm if this is expected or not
@taimurCognizant the designs you’re looking at there are not in context. On the modal designs you find a better example. The vertical margins come from the section, and we should check/finetune this when setting up a page

Copy link
Contributor

aem-code-sync bot commented Nov 16, 2023

Page Scores Audits Google
/drafts/lakshmi/text PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@cogniSyb cogniSyb changed the title Text Block 181 V2 Text Block Text Block 181 Nov 16, 2023
@cogniSyb cogniSyb changed the title V2 Text Block Text Block 181 V2 Text Block #181 Nov 16, 2023
@cogniSyb cogniSyb merged commit 7ca920a into develop Nov 16, 2023
@cogniSyb cogniSyb added the FR Functional requirement label Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FR Functional requirement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants