Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CR - Truck Carousel description font weight is heavier than what is displayed in Figma #220

Open
ZoeBeykirch opened this issue Oct 16, 2023 · 3 comments
Labels
Enhancement New feature or request Homepage template where this is used Moved to prod repo Migrated to the production project

Comments

@ZoeBeykirch
Copy link
Collaborator

For the Truck Carousel block on the redesign homepage, the truck description font weight is heavier than what is displayed in Figma.

Current Result:

Image

Desired Result:
https://www.figma.com/file/IcqreRKnNYyDVMc28yoOeh/Homepage?type=design&node-id=4259%3A4276&mode=dev

@ZoeBeykirch ZoeBeykirch added Bugfix Homepage template where this is used labels Oct 16, 2023
@cogniSyb
Copy link
Collaborator

This part of the design has been changed along the way. The font-weight is 350, which is different from the rest of the regular text (400). I ran through the rest of the designs, and we also have the pretitle with font-weight 300. Can I safely assume that we would need to add "Volvo Novum SemiLight" and "Volvo Novum Light" to the project?

Performance-wise I don’t want to add two new font files to the project, especially if their appearance is so similar. Can we pick one weight to use for both pretitle and this text?

@ZoeBeykirch
Copy link
Collaborator Author

@csulitzer Based on discussion with Saamia/Ozzy this morning, please update this ticket once design team has a recommendation

@DanielaPedrochevd DanielaPedrochevd changed the title Bug - Minor - Truck Carousel description font weight is heavier than what is displayed in Figma CR - Truck Carousel description font weight is heavier than what is displayed in Figma Oct 19, 2023
@DanielaPedrochevd DanielaPedrochevd added Enhancement New feature or request and removed Bugfix labels Oct 19, 2023
@shirin27
Copy link
Collaborator

Kamino cloned this issue to hlxsites/vg-volvotrucks-us

@shirin27 shirin27 added the Moved to prod repo Migrated to the production project label Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Homepage template where this is used Moved to prod repo Migrated to the production project
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

4 participants