Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug - Social block Visual QA issues #289

Closed
DanielaPedrochevd opened this issue Dec 12, 2023 · 2 comments
Closed

Bug - Social block Visual QA issues #289

DanielaPedrochevd opened this issue Dec 12, 2023 · 2 comments
Assignees
@TomaszDziezykNetcentric @Andrei-Boiangiu
Labels
Bugfix
Milestone
Volvo Digital Rev...

Comments

@DanielaPedrochevd
Copy link

How to reproduce

  1. Go to https://develop--vg-volvotrucks-us-rd--netcentric.hlx.page/drafts/tdziezyk/v2/pre-reveal-event-modal (or any digital reveal page that contains the social block)
  2. Scroll to the social block

Expected Result

On tablet and mobile, text size should be body regular 2 (18px) and spacing between social icons on desktop and tablet should be 40px, and on mobile: 24px

Image

Actual Result
There is a wider spacing and the font is not the same.

Image
@DanielaPedrochevd
Copy link
Author

related to #220

TomaszDziezykNetcentric pushed a commit that referenced this issue Dec 14, 2023
@tdziezykDS
#289 Update heading and icons styles
016ecc9
Merged
TomaszDziezykNetcentric pushed a commit that referenced this issue Dec 15, 2023
@tdziezykDS
#289 Update social text color
e23a237
@Andrei-Boiangiu
Copy link

confirmed as fixed
as tested on https://289-social-block-qa-issues--vg-volvotrucks-us-rd--netcentric.hlx.page/tools/sidekick/library.html?plugin=blocks&path=/block-library/blocks/v2-social-block&index=0

cogniSyb pushed a commit that referenced this issue Dec 18, 2023
@TomaszDziezykNetcentric
Social block Visual QA issues #289 (#306)
ae82273 
* #289 Update heading and icons styles
* #289 Update social text color
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TomaszDziezykNetcentric TomaszDziezykNetcentric

@Andrei-Boiangiu Andrei-Boiangiu

Labels
Bugfix
Projects
None yet
Milestone
Volvo Digital Reveal
Development

No branches or pull requests
3 participants
@TomaszDziezykNetcentric @Andrei-Boiangiu @DanielaPedrochevd