401 franklin sidekick library #402
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
Victor-AcostaCNC
requested review from
nc-andreashaller,
tomasznetcentric and
alexnerdrumhansen
|
|
We need to merge the Sidekick library code into the main branch in order to be able to configure the library |
tools/sidekick/library.html
Outdated
| <body> | ||
| <script | ||
| type="module" | ||
| src="https://www.hlx.live/tools/sidekick/library/index.js" |
There was a problem hiding this comment.
I think we should switch it to https://www.aem.live/tools/sidekick/library/index.js
tools/sidekick/library.html
Outdated
| <script> | ||
| const library = document.createElement('sidekick-library') | ||
| library.config = { | ||
| base: '/block-library/library.json', |
There was a problem hiding this comment.
shouldn't this be /tools/sidekick/library.json ?
There was a problem hiding this comment.
do you mean /tools/sidekick/config.json?
There was a problem hiding this comment.
tools/sidekick/config.json
Outdated
| @@ -1,4 +1,6 @@ | |||
| { | |||
| "project": "CN Web", | |||
| "host": "main--cn-website--netcentric.hlx.page/", | |||
There was a problem hiding this comment.
are you sure we need this?
There was a problem hiding this comment.
We can remove the project for sure but I am not so sure about removing the host
There was a problem hiding this comment.
where did you get it from and why does it need to point to the preview URL?
|
|
|
|
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #401
Test URLs: