Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedicated OSGi configuration for granting access to UI #782

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

kwin
Copy link
Member

@kwin kwin commented Jan 31, 2025

No longer leverage PID SlingWebConsoleSecurityProvider as previously interpolated values were not resolved correctly.

This closes #781

@kwin kwin requested a review from ghenzler January 31, 2025 19:04
@kwin kwin force-pushed the bugfix/authorization branch 2 times, most recently from 6510c92 to e272aaa Compare February 1, 2025 10:43
@kwin kwin marked this pull request as ready for review February 1, 2025 10:43
@kwin kwin force-pushed the bugfix/authorization branch 2 times, most recently from b04dd6b to 483239e Compare February 1, 2025 10:46
@kwin kwin mentioned this pull request Feb 1, 2025
@kwin kwin force-pushed the bugfix/authorization branch from 483239e to d7e74c3 Compare February 2, 2025 10:31
@kwin kwin requested a review from Positronic-Brain February 4, 2025 10:18
# User Interface

There is a Felix Web Console plugin (at `/system/console/actool`) as well as a Touch UI console (at `/mnt/overlay/netcentric/actool/content/overview.html`) to apply configurations and to inspect previous executions of the tool. Additionally there is a [JMX interface](docs/Jmx.md) for some advanced use cases.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should leave this documentation in (or just adjust it)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t like duplication. This is described in the other md file

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I restored it and linked out to the other page now.

@kwin kwin force-pushed the bugfix/authorization branch from d7e74c3 to 9638820 Compare February 4, 2025 10:51
No longer leverage PID SlingWebConsoleSecurityProvider as
defaults no longer reasonably set in AEMaaCS.
Disable action buttons depending on permissions.

Clean up HistoryUtils to leverage JcrUtils

This closes #781
@kwin kwin force-pushed the bugfix/authorization branch from 9638820 to e9f6f6c Compare February 4, 2025 10:52
@kwin kwin merged commit 892a0c3 into develop Feb 4, 2025
18 checks passed
@kwin kwin deleted the bugfix/authorization branch February 4, 2025 10:57
Copy link

sonarqubecloud bot commented Feb 4, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 31%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Permission denied error
2 participants