Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 调整stylelint-taro-rn所以依赖的stylelint版本 #17146

Merged
merged 8 commits into from
Jan 13, 2025

Conversation

prot3in
Copy link
Contributor

@prot3in prot3in commented Jan 4, 2025

这个 PR 做了什么? (简要描述所做更改)
调整了stylelint-taro-rn所依赖的stylelint版本。
项目中引用的文件'stylelint\lib\utils\declarationValueIndex.cjs''stylelint 16.11.0后被移除,如果继续使用^16.4.0标记版本,那么最近创建的rn项目在构建时会报错error: src\app.css: Cannot find module '{projectPath}\node_modules\.pnpm\[email protected][email protected]\node_modules\stylelint\lib\utils\declarationValueIndex.cjs' imported from {projectPath}\node_modules\.pnpm\[email protected][email protected]\node_modules\stylelint-taro-rn\dist\index.esm.js

这个 PR 是什么类型? (至少选择一个)

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台(QuickApp)
  • Web 平台(H5)
  • 移动端(React-Native)
  • 鸿蒙(harmony)

@tutuxxx tutuxxx requested a review from zhiqingchen January 6, 2025 07:12
@zhiqingchen
Copy link
Member

thanks

@zhiqingchen
Copy link
Member

@prot3in 这个 pr 需要更新 lock 文件

@prot3in prot3in force-pushed the fix/stylelint-taro-rn branch from 13c8fa1 to 7bcfd03 Compare January 10, 2025 08:57
@prot3in
Copy link
Contributor Author

prot3in commented Jan 10, 2025

@prot3in 这个 pr 需要更新 lock 文件

已更新

@zhiqingchen
Copy link
Member

CI 有 bug,待修复 @luckyadam

@tutuxxx
Copy link
Member

tutuxxx commented Jan 13, 2025

CI 有 bug,待修复 @luckyadam

@zhiqingchen 已修复

@tutuxxx
Copy link
Member

tutuxxx commented Jan 13, 2025

@prot3in 这个 pr 需要更新 lock 文件

已更新

修改stylelint版本后,我本地pnpm i lock文件只有一行变动,请确认下lock文件的变更范围:
image

我本地环境:
▶ node -v
v18.18.2
▶ pnpm -v
9.12.2

@prot3in

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.52%. Comparing base (cbcdd87) to head (132f610).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main   #17146    +/-   ##
========================================
  Coverage   58.52%   58.52%            
========================================
  Files         468      468            
  Lines       27136    27136            
  Branches     5955     5929    -26     
========================================
  Hits        15882    15882            
+ Misses       9899     9740   -159     
- Partials     1355     1514   +159     
Flag Coverage Δ
taro-cli 72.37% <ø> (ø)
taro-runtime 59.87% <ø> (ø)
taro-web 52.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 29 files with indirect coverage changes

@prot3in
Copy link
Contributor Author

prot3in commented Jan 13, 2025

@prot3in 这个 pr 需要更新 lock 文件

已更新

修改stylelint版本后,我本地pnpm i lock文件只有一行变动,请确认下lock文件的变更范围: image

我本地环境: ▶ node -v v18.18.2 ▶ pnpm -v 9.12.2

@prot3in

已更改,我之前 pnpm 版本是 9.0.9 ,改为 9.12.2 后和你一致。

@zhiqingchen zhiqingchen merged commit 8ed62b9 into NervJS:main Jan 13, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants