Store active job cache pointer in Zookeeper #2681
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alerman
reviewed
Jan 7, 2025
warehouse/ingest-scripts/src/main/resources/bin/ingest/findJars.sh
Outdated
Show resolved
Hide resolved
|
I like it, nice work! |
jalphonso
previously approved these changes
Jan 7, 2025
awrigh11
approved these changes
Jan 7, 2025
alerman
approved these changes
Jan 7, 2025
apmoriarty
approved these changes
Jan 8, 2025
hlgp
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to store the active job cache somewhere accessible to services not running on ingestmaster. The team decided to go with zookeeper.
I updated load-job-cache.sh to call a java utility to set the active job cache as doing it in bash was non-trivial as you have to recursively create ZK paths if they do not exist.
Honestly, we may want to consider moving the whole load-job-cache functionality into java as that bash script is pretty hefty. We'd be able to test it and probably read it easier. But for now, I just set the active job cache in ZK.