feat: allow multiple phone and email records for contact information #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EchoMi0
requested changes
Feb 7, 2025
Comment on lines
+43
to
+127
| <FieldArray | ||
| name="phone" | ||
| render={ () => ( | ||
| <> | ||
| <label className='group-subtitle-style mb-1 self-start'>Telefon</label> | ||
| {values.contactInfo.map((contact, index) => ( | ||
| contact.contact_type === 'phone' && ( | ||
| <div key={index} className='flex flex-col'> | ||
|
|
||
| <div> | ||
| <div className='flex flex-row mb-3'> | ||
| <Field | ||
| type='text' | ||
| id={`contactInfo[${index}].contact_value`} | ||
| className='input-text-style' | ||
| onChange={handleChange} | ||
| onBlur={handleBlur} | ||
| value={contact.contact_value ?? ''} | ||
| /> | ||
| <button | ||
| type="button" | ||
| className="row-action-button-style" | ||
| onClick={() => handleRemove(values, index)} | ||
| > | ||
| <FaCircleMinus size={24} className='text-blue-500'/> | ||
| </button> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| ) | ||
| ))} | ||
| <Button | ||
| type="button" | ||
| variant="light" | ||
| color="primary" | ||
| className='text-md' | ||
| onClick={() => handleAdd(values, 'phone')} | ||
| > | ||
| + Legg til telefon | ||
| </Button> | ||
| </> | ||
| )} | ||
| /> | ||
|
|
||
| <label htmlFor='contact_phone' className='group-subtitle-style mb-1 self-start'> Telefon </label> | ||
| <Field | ||
| type='text' | ||
| id='contact_phone' | ||
| className='input-text-style' | ||
| onChange={handleChange} | ||
| onBlur={handleBlur} | ||
| value={values.contact_phone ?? ''} | ||
| <FieldArray | ||
| name="email" | ||
| render={ () => ( | ||
| <> | ||
| <label className='group-subtitle-style mb-1 self-start'>E-post</label> | ||
| {values.contactInfo.map((contact, index) => ( | ||
| contact.contact_type === 'email' && ( | ||
| <div key={index} className='flex flex-col'> | ||
| <div> | ||
| <div className='flex flex-row mb-3'> | ||
| <Field | ||
| type='text' | ||
| id={`contactInfo[${index}].contact_value`} | ||
| className='input-text-style' | ||
| onChange={handleChange} | ||
| onBlur={handleBlur} | ||
| value={contact.contact_value ?? ''} | ||
| /> | ||
| <button | ||
| type="button" | ||
| className="row-action-button-style" | ||
| onClick={() => handleRemove(values, index)} | ||
| > | ||
| <FaCircleMinus size={24} className='text-blue-500'/> | ||
| </button> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| ) | ||
| ))} | ||
| <Button | ||
| type="button" | ||
| variant="light" | ||
| color="primary" | ||
| className="text-md" | ||
| onClick={() => handleAdd(values, 'email')} | ||
| > | ||
| + Legg til e-post | ||
| </Button> | ||
| </> | ||
| )} |
There was a problem hiding this comment.
Vurder å lage komponent av disse, ganske like.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fjernet ContactAndReleaseInfo.tsx da dette ble et rart abstraksjonslag hvor man stor sett bare sendte gjennom props og som gjorde den vanskelig å jobbe med.
Inneholder også patch oppdatering av next pga. sårbarheter pluss noe mindre refaktorering der deler av større komponenter ble delt inn i mindre komponenter (SuccessAlert og TitleNotFound).