Add runtime histogram metric #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zilm13
reviewed
Oct 21, 2024
| import org.hyperledger.besu.plugin.services.MetricsSystem; | ||
| import org.hyperledger.besu.plugin.services.metrics.MetricCategory; | ||
|
|
||
| public class SettableHistogram { |
There was a problem hiding this comment.
I'd call it MetricsHistogram and rename current MetricsHistogram to MetricsQuantileHistogram
| String name, | ||
| String help, | ||
| double... buckets) { | ||
| this.name = name; |
There was a problem hiding this comment.
Just this(metricsSystem, category, name, help, new String[0], buckets); would do all job without duplicating
| } | ||
| } | ||
|
|
||
| protected Collector histogramToCollector(final MetricCategory metricCategory, final String name) { |
There was a problem hiding this comment.
Please, remove unused inputs
| @@ -25,7 +25,11 @@ dependencies { | |||
| implementation project(':storage') | |||
| implementation project(':storage:api') | |||
|
|
|||
| implementation testFixtures(project(':infrastructure:metrics')) | |||
There was a problem hiding this comment.
please remove all new implementations, we will avoid exposing anything outside of infrastructure:metrics instead
| } | ||
| } | ||
|
|
||
| public Timer startTimer(String... labelValues) { |
There was a problem hiding this comment.
To avoid exposing prometheus timer outside, let's wrap it here. Make inner class like this, and return it here
public record Timer(Histogram.Timer delegate) implements Closeable {
@Override
public void close() throws IOException {
delegate.close();
}
}
zilm13
reviewed
Oct 22, 2024
| DataColumnSidecarGossipValidator validator, DasGossipLogger dasGossipLogger) { | ||
| DataColumnSidecarGossipValidator validator, | ||
| DasGossipLogger dasGossipLogger, | ||
| MetricsSystem metricsSystem) { |
| listener -> listener.onNewValidSidecar(dataColumnSidecar)); | ||
| } | ||
| }); | ||
| SafeFuture<InternalValidationResult> validation; |
| try (Timer ignored = histogram.startTimer()) { | ||
| validation = validator.validate(dataColumnSidecar); | ||
| } catch (final Throwable t) { | ||
| LOG.error("Failed to validate data column sidecar", t); |
There was a problem hiding this comment.
Let's log datacolumnsidecar too.Something like this
LOG.error("Failed to validate data column sidecar {}", dataColumnSidecar::toLogString, () -> t);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Add histogram timer and
beacon_data_column_sidecar_gossip_verification_secondsPeerDAS metricFixed Issue(s)
fixes #65