Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allocator: rename to avoid shadow warning #47

Closed
wants to merge 1 commit into from

Conversation

dowens-pp
Copy link
Contributor

@dowens-pp dowens-pp commented Apr 6, 2022

@Naios

rename 'allocator' --> '_allocator' to prevent shadowing gcc
declaration.


What was a problem?

Addresses item #2 in #30

How this PR fixes the problem?

renames 'allocator' to '_allocator' to avoid redeclaration warning

Check lists (check x in [ ] of list items)

  • Additional Unit Tests were added that test the feature or regression
  • Coding style (Clang format was applied)

Additional Comments (if any)

no functional changes, only warning elimination when using gcc.

rename 'allocator' --> '_allocator' to prevent shadowing gcc
declaration.

Signed-off-by: David Owens <[email protected]>
@dowens-pp dowens-pp requested a review from Naios as a code owner April 6, 2022 22:03
@Naios Naios closed this in a4ca93c May 16, 2022
@Naios
Copy link
Owner

Naios commented May 16, 2022

Thank you for your contribution.

I renamed the allocators to allocator_, leading underscore is usually a compiler reserved identifier: https://stackoverflow.com/a/228797/2303378

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants