Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test cases #60

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Add test cases #60

merged 2 commits into from
Jan 24, 2025

Conversation

ritikasrivastava
Copy link
Collaborator

No description provided.

@ritikasrivastava
Add test cases
a6d5948 
Signed-off-by: Ritika Srivastava <[email protected]>
@ritikasrivastava ritikasrivastava self-assigned this Jan 23, 2025
dmitsh
dmitsh reviewed Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@dmitsh dmitsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we use functions like GetBlockWithIBTestSet() anywhere except tests?
Perhaps we can move them from output.go to output_test.go?

@ritikasrivastava
Move unexported functions
7bdda47 
Signed-off-by: Ritika Srivastava <[email protected]>
@ritikasrivastava
Copy link
Collaborator Author

ritikasrivastava commented Jan 24, 2025 •
edited
Loading

Do we use functions like GetBlockWithIBTestSet() anywhere except tests? Perhaps we can move them from output.go to output_test.go?

Moved the unexported functions to _test.go

@ritikasrivastava ritikasrivastava merged commit 9166017 into main Jan 24, 2025
4 checks passed
@ritikasrivastava ritikasrivastava deleted the ritika/unittest branch January 24, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitsh dmitsh dmitsh approved these changes

@pkedy pkedy Awaiting requested review from pkedy

@sanjaychatterjee sanjaychatterjee Awaiting requested review from sanjaychatterjee sanjaychatterjee is a code owner

Assignees

@ritikasrivastava ritikasrivastava

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ritikasrivastava @dmitsh