Config parameters #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uration file Signed-off-by: Henry Haase <[email protected]>
Signed-off-by: Henry Haase <[email protected]>
Signed-off-by: Henry Haase <[email protected]>
|
I have identified that there is an issue caused by the merge of PR #12 that causes topograph to crash when requesting simulated block topology. Will also try to fix this issue in this PR. |
Signed-off-by: Dmitry Shmulevich <[email protected]>
* Blocksize refactoring 1. Domain sizes may vary 2. Return block size as largest power of 2, less than the minimum domain size 3. Verify admin provided blocksize > 0 and <= minimum domain size Signed-off-by: Ritika Srivastava <[email protected]> * Catch strconv error Signed-off-by: Ritika Srivastava <[email protected]> --------- Signed-off-by: Ritika Srivastava <[email protected]>
Signed-off-by: Henry Haase <[email protected]>
Signed-off-by: Henry Haase <[email protected]>
Signed-off-by: Henry Haase <[email protected]>
Signed-off-by: Henry Haase <[email protected]>
Signed-off-by: Henry Haase <[email protected]>
dmitsh
reviewed
Oct 30, 2024
Signed-off-by: Henry Haase <[email protected]>
Signed-off-by: Henry Haase <[email protected]>
Signed-off-by: Henry Haase <[email protected]>
dmitsh
requested changes
Oct 31, 2024
Signed-off-by: Henry Haase <[email protected]>
dmitsh
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A pull request that adds a few parameters to the topograph config file and makes most payload arguments in the request JSON optional.