Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CUDA version definition in benchmark script [skip ci] #529

Merged
merged 8 commits into from
Dec 8, 2023
Merged

Remove CUDA version definition in benchmark script [skip ci] #529

merged 8 commits into from
Dec 8, 2023

Conversation

YanxuanLiu
Copy link
Collaborator

@YanxuanLiu YanxuanLiu commented Dec 7, 2023 •
edited
Loading

Change default cuda version to 12.2.2, same as spark-rapids-ml-benchmarking/benchmark/spark-rapids.sh

@YanxuanLiu
Copy link
Collaborator Author

Test build:

https://github.com/YanxuanLiu/spark-rapids-ml/actions/runs/7137075866/job/19436497641

@YanxuanLiu YanxuanLiu changed the title changed default cuda version from 11.8 to 11.8.0 changed default cuda version from 11.8 to 12.2.2 [skip ci] Dec 8, 2023
@YanxuanLiu
add if
902ff2c 
Signed-off-by: YanxuanLiu <[email protected]>
@YanxuanLiu
Copy link
Collaborator Author

build

@YanxuanLiu YanxuanLiu marked this pull request as ready for review December 8, 2023 04:32
NvTimLiu
NvTimLiu previously approved these changes Dec 8, 2023
View reviewed changes
Copy link
Collaborator

@NvTimLiu NvTimLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YanxuanLiu
remove cuda version
8f638e6 
Signed-off-by: YanxuanLiu <[email protected]>
@YanxuanLiu YanxuanLiu changed the title changed default cuda version from 11.8 to 12.2.2 [skip ci] Remove CUDA version definition in benchmark script [skip ci] Dec 8, 2023
@YanxuanLiu
Copy link
Collaborator Author

re-built without CUDA version:

https://github.com/YanxuanLiu/spark-rapids-ml/actions/runs/7137780890/job/19438268097

@YanxuanLiu
add if
3c7d8c7 
Signed-off-by: YanxuanLiu <[email protected]>
@YanxuanLiu
Copy link
Collaborator Author

build

@YanxuanLiu YanxuanLiu self-assigned this Dec 8, 2023
NvTimLiu
NvTimLiu approved these changes Dec 8, 2023
View reviewed changes
Copy link
Collaborator

@NvTimLiu NvTimLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good not set cuda-version to leverage the default cuda/driver defined in the GCP spark-rapids.sh file

@YanxuanLiu YanxuanLiu merged commit c2b997f into NVIDIA:branch-23.12 Dec 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NvTimLiu NvTimLiu NvTimLiu approved these changes

@leewyang leewyang Awaiting requested review from leewyang

@pxLi pxLi Awaiting requested review from pxLi

Assignees

@YanxuanLiu YanxuanLiu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YanxuanLiu @NvTimLiu