load data before comms and nccl abort to solve issues with empty partitions #464
+44
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
build |
eordentlich
commented
Oct 7, 2023
| @@ -326,7 +326,7 @@ def test_nearest_neighbors( | |||
| random_state=0, | |||
| ) # make_blobs creates a random dataset of isotropic gaussian blobs. | |||
|
|
|||
| # set average norm to be 1 to allow comparisons with default error thresholds | |||
| # set average norm sq to be 1 to allow comparisons with default error thresholds | |||
There was a problem hiding this comment.
This was still wrong so correcting in this PR.
leewyang
previously approved these changes
Oct 9, 2023
|
Did some benchmarking with 2 gpus and the change (additional barrier) seems to add 1sec of latency to fit. |
Signed-off-by: Erik Ordentlich <[email protected]>
Signed-off-by: Erik Ordentlich <[email protected]>
Signed-off-by: Erik Ordentlich <[email protected]>
eordentlich
force-pushed
the
eo_fix_empty_partition_hangs
branch
from
2e609ac to
5642383
Compare
eordentlich
changed the title
|
build |
|
Moving data loading before nccl comms setup seems to also solve the issues without the extra barrier in previous version. Tested with uvm on databricks and seems to be ok. |
leewyang
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In further testing of handling of empty partitions added previously on workstation and dgx (local mode) found that even though we now raise an exception in this case, this can still result in hangs in python workers. Sometimes the job hangs (dgx) and other times exits but the python worker isn't killed (docker on local workstation).
Loading data before setting up comms (to prevent a worker with data from racing ahead and starting e.g an allreduce) and the nccl abort seems to clean things up in these cases.
I don't think this is the root cause of #453 but should be addressed.