BugFix: Abort on certain response codes and retry on others #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… down into response code and further group errors as ones that should be retried and ones that are hard failures
drobison00
requested changes
Jan 29, 2025
| # There are a plethora of codes that can be thrown. Some offer specific insights while | ||
| # others can be grouped into a general failure category. We check for specific codes here | ||
| # and then generally error on the others. | ||
| if response.response_code == 404: |
There was a problem hiding this comment.
I don't know if we want to make the generic client aware of HTTP response codes. It's also used for Redis/SimpleBroker, and whatever else we may need to support in the future.
Maybe we just have recoverable vs non-recoverable response codes that it knows about and translate errors from the different client instances into those?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The previous logic grouped all possible HTTP response codes into the same "bucket". This meant that any response received from the server would result in a retry. Some HTTP response codes like 404 & 500 are unlikely to remediate themselves with a retry with the extra same input and conditions and therefore spam the client with nearly unlimited retries. This PR adjust that logic to instead through RuntimeErrors in those conditions and offer a placeholder where other conditions of that manner can later be added as well.
This closes #382
Checklist