Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Incorrect behavior with REST client's 'fetch_message' API when a job ID does not exist. #382

Open
drobison00 opened this issue Jan 28, 2025 · 1 comment · May be fixed by #387
Open
Labels
bug Something isn't working

Comments

@drobison00
Copy link
Collaborator

Version

24.10

Which installation method(s) does this occur on?

No response

Describe the bug.

When using the REST Client to fetch a message from FastAPI, if the job ID does not exist, the Rest proxy will immediately return a '404', and the client will immediately re-issue the fetch request. This results in 'spamming' the log outputs, with something similar to the snippet below.

This is incorrect behaviorally: we should engage in some kind of exponential backoff to avoid flooding the user, and recognize that there is a failure if the job ID does not exist after some grace period.

This is also incorrect technically: the 404 isn't a timeout, its an HTTP request failure.

DEBUG:nv_ingest_client.util.processing:Error processing future result: Timeout: No response within 10 seconds for job ID 0
DEBUG:nv_ingest_client.message_clients.rest.rest_client:Invoking fetch_message http endpoint @ 'http://localhost:7670/v1/fetch_job/'
DEBUG:urllib3.connectionpool:Starting new HTTP connection (1): localhost:7670

Minimum reproducible example

No direct reproducer, this behavior was discovered when diagnosing another issue where a submit_message call to the FastAPI service was failing and silently failing job creation.

Relevant log output

Other/Misc.

No response

@drobison00 drobison00 added the bug Something isn't working label Jan 28, 2025
@drobison00 drobison00 changed the title [BUG]: [BUG]: Incorrect behavior with REST client's 'fetch_message' API when a job ID does not exist. Jan 28, 2025
@drobison00
Copy link
Collaborator Author

@jdye64 Could you take a look at this when you have a chance?

@jdye64 jdye64 linked a pull request Jan 29, 2025 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant