Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement task for configuring virtual nodes #46

Merged
merged 1 commit into from
May 20, 2024
Merged

implement task for configuring virtual nodes #46

merged 1 commit into from
May 20, 2024

Conversation

dmitsh
Copy link
Collaborator

@dmitsh dmitsh commented May 20, 2024

This task configures number and flavor of virtual nodes.

@dmitsh dmitsh force-pushed the ds-config branch 5 times, most recently from 8a34334 to 33b8494 Compare May 20, 2024 04:41
@dmitsh dmitsh changed the title implement task for configuring the nodes implement task for configuring virtual nodes May 20, 2024
pkg/engine/configure_task.go Outdated Show resolved Hide resolved
pkg/engine/configure_task.go Show resolved Hide resolved
docs/deployment.md Show resolved Hide resolved
pkg/engine/configure_task.go Show resolved Hide resolved
@dmitsh dmitsh force-pushed the ds-config branch 2 times, most recently from b1bf77c to ea47832 Compare May 20, 2024 15:28
@dmitsh dmitsh requested a review from lalitadithya May 20, 2024 15:31
Copy link
Collaborator

@yuanchen8911 yuanchen8911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@yuanchen8911
Copy link
Collaborator

I'll update the demo script and recreate the demo after the PR is merged.

@dmitsh dmitsh merged commit 98977eb into main May 20, 2024
4 checks passed
@dmitsh dmitsh deleted the ds-config branch May 20, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants