Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed error when deleting already deleted object #45

Merged
merged 2 commits into from
May 17, 2024
Merged

fixed error when deleting already deleted object #45

merged 2 commits into from
May 17, 2024

Conversation

dmitsh
Copy link
Collaborator

@dmitsh dmitsh commented May 17, 2024

When deleting with "-cleanup" flag, some of the objects might have already expired or been deleted previously.
In such cases knavigator prints a warning instead of returning an error.

@dmitsh dmitsh requested review from yuanchen8911 and shinae-woo May 17, 2024 17:49
pkg/engine/engine.go Show resolved Hide resolved
@yuanchen8911 yuanchen8911 self-requested a review May 17, 2024 18:01
Copy link
Collaborator

@yuanchen8911 yuanchen8911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@dmitsh dmitsh merged commit 8be8b2b into main May 17, 2024
4 checks passed
@dmitsh dmitsh deleted the ds-fix-del branch May 17, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants