Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add git workflow for a test that submits a k8s job #35

Merged
merged 2 commits into from
May 21, 2024

Conversation

shinae-woo
Copy link
Collaborator

No description provided.

@shinae-woo
Copy link
Collaborator Author

/test-k8s

@shinae-woo shinae-woo force-pushed the test-workflow branch 7 times, most recently from 13a7f64 to 69cd14e Compare May 16, 2024 23:21
@@ -1,7 +1,7 @@
# This workflow will build a golang project
# For more information see: https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-go

name: Go
name: PR Checks
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename it back to Go. I think it is expected.

Comment on lines 111 to 114
kubectl create ns k8s-test
kubectl create priorityclass normal-priority --value=100000
./bin/knavigator -tasks resources/tests/k8s/test-job.yml
kubectl get job -n k8s-test
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: replace lines 111-114 with:
./bin/knavigator -tasks resources/tests/k8s/test-job.yml
kubectl get job
kubectl get pod
kubectl delete job job1

@shinae-woo shinae-woo force-pushed the test-workflow branch 11 times, most recently from 02b82fa to b7499e3 Compare May 21, 2024 19:52
@shinae-woo shinae-woo force-pushed the test-workflow branch 2 times, most recently from 229ee0e to 05b0032 Compare May 21, 2024 20:30
@shinae-woo shinae-woo merged commit f777993 into NVIDIA:main May 21, 2024
5 checks passed
@shinae-woo shinae-woo deleted the test-workflow branch May 21, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants