Skip to content

Commit

Permalink
update jobset configs
Browse files Browse the repository at this point in the history
Signed-off-by: Dmitry Shmulevich <[email protected]>
  • Loading branch information
dmitsh committed Aug 17, 2024
1 parent 320d1ec commit cd85c38
Show file tree
Hide file tree
Showing 11 changed files with 18 additions and 18 deletions.
4 changes: 2 additions & 2 deletions docs/examples/jobset/jobset.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ kubectl apply --server-side -f https://github.com/kubernetes-sigs/jobset/release

Run a jobset with workers:
```shell
./bin/knavigator -workflow ./resources/workflows/k8s/test-jobset.yml
./bin/knavigator -workflow ./resources/workflows/jobset/test-jobset.yaml
```

Run a jobset with a driver and workers:
```shell
./bin/knavigator -workflow ./resources/workflows/k8s/test-jobset-with-driver.yml
./bin/knavigator -workflow ./resources/workflows/jobset/test-jobset-with-driver.yaml
```
4 changes: 2 additions & 2 deletions docs/examples/kueue/kueue.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ kubectl apply -f charts/overrides/kueue/priority.yaml

Run a kueue job:
```bash
./bin/knavigator -workflow resources/workflows/kueue/test-job.yml -cleanup
./bin/knavigator -workflow resources/workflows/kueue/test-job.yaml -cleanup
```

Run a preemption workflow with kueue:
```bash
./bin/knavigator -workflow resources/workflows/kueue/test-preemption.yml -cleanup
./bin/knavigator -workflow resources/workflows/kueue/test-preemption.yaml -cleanup
```
2 changes: 1 addition & 1 deletion pkg/config/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ func TestWorkflowPaths(t *testing.T) {
},
{
name: "Case 3: Valid input",
paths: "../../resources/workflows/volcano,../../resources/workflows/k8s/{test-job.yml,test-jobset.yml}",
paths: "../../resources/workflows/volcano,../../resources/workflows/kueue/{test-job.yaml,test-preemption.yaml}",
count: 3,
},
}
Expand Down
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ tasks:
- id: register
type: RegisterObj
params:
template: "resources/templates/k8s/jobset-with-driver.yml"
template: "resources/templates/jobset/jobset-with-driver.yaml"
nameFormat: "jobset{{._ENUM_}}"
podNameFormat: "{{._NAME_}}-(worker|driver)-[0-9]+-[0-9]+-.+"
podCount: "{{.replicas}}"
podNameFormat: "{{._NAME_}}-(workers|driver)-[0-9]+-[0-9]+-.+"
podCount: "{{.replicas}} * 2"
- id: configure
type: Configure
params:
Expand All @@ -47,10 +47,10 @@ tasks:
cpu: 100m
memory: 512M
gpu: 8
ttl: "10s"
ttl: "20s"
- id: status
type: CheckPod
params:
refTaskId: jobset
status: Running
timeout: 5s
timeout: 10s
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ tasks:
- id: register
type: RegisterObj
params:
template: "resources/templates/k8s/jobset.yml"
template: "resources/templates/jobset/jobset.yaml"
nameFormat: "jobset{{._ENUM_}}"
podNameFormat: "{{._NAME_}}-workers-[0-9]+-[0-9]+-.+"
podCount: "{{.replicas}}"
Expand Down Expand Up @@ -47,10 +47,10 @@ tasks:
cpu: 100m
memory: 512M
gpu: 8
ttl: "10s"
ttl: "20s"
- id: status
type: CheckPod
params:
refTaskId: jobset
status: Running
timeout: 5s
timeout: 10s
Original file line number Diff line number Diff line change
Expand Up @@ -88,18 +88,18 @@ tasks:
cpu: 100m
memory: 512M
gpu: 8
ttl: "10s"
ttl: "20s"
- id: status
type: CheckObj
params:
refTaskId: job
state:
status:
active: 3
timeout: 5s
timeout: 10s
- id: status
type: CheckPod
params:
refTaskId: job
status: Running
timeout: 5s
timeout: 10s
2 changes: 1 addition & 1 deletion tests/ci/test_jobset.sh
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ deploy_kwok
deploy_jobset

# Run knavigator with an example test
${REPO_HOME}/bin/knavigator -workflow ${REPO_HOME}/resources/workflows/k8s/test-jobset.yml -v 4 -cleanup
${REPO_HOME}/bin/knavigator -workflow ${REPO_HOME}/resources/workflows/jobset/test-jobset.yaml -v 4 -cleanup
2 changes: 1 addition & 1 deletion tests/ci/test_kueue.sh
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ deploy_kwok
deploy_kueue

# Run knavigator with an example test
${REPO_HOME}/bin/knavigator -workflow ${REPO_HOME}/resources/workflows/kueue/test-job.yml -v 4 -cleanup
${REPO_HOME}/bin/knavigator -workflow ${REPO_HOME}/resources/workflows/kueue/test-job.yaml -v 4 -cleanup

0 comments on commit cd85c38

Please sign in to comment.