Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add script to clean-up unused AWS EC2 Instances and VPCs #244

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Add script to clean-up unused AWS EC2 Instances and VPCs #244

merged 1 commit into from
Jan 15, 2025

Conversation

shivakunv
Copy link
Contributor

No description provided.

@shivakunv shivakunv force-pushed the awsresourcecleanup branch 3 times, most recently from 2f8369e to 348e3c1 Compare December 17, 2024 08:13
@shivakunv shivakunv self-assigned this Dec 17, 2024
@shivakunv shivakunv marked this pull request as ready for review December 17, 2024 08:13
@shivakunv shivakunv mentioned this pull request Dec 17, 2024
Closed
shivakunv
shivakunv commented Dec 17, 2024
View reviewed changes
scripts/awsvpcscleanup.sh Outdated Show resolved Hide resolved
shivakunv
shivakunv commented Dec 17, 2024
View reviewed changes
scripts/awsvpcscleanup.sh Outdated Show resolved Hide resolved
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 18, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@shivakunv shivakunv force-pushed the awsresourcecleanup branch 11 times, most recently from bd378e0 to 5a06340 Compare December 19, 2024 06:08
@tariq1890
Copy link
Contributor

@shivakunv It'd be better if the cleanup bot follows the same sequence of operations as laid out in the holodeck delete.go file

@shivakunv
Copy link
Contributor Author

shivakunv commented Dec 19, 2024 •
edited
Loading

passed piepline :
https://github.com/NVIDIA/holodeck/actions/runs/12416007697/job/34665439014

@shivakunv
Copy link
Contributor Author

@shivakunv It'd be better if the cleanup bot follows the same sequence of operations as laid out in the holodeck delete.go file

followed delete.go sequence:-

terminateInstancesInput
deleteSecurityGroup
Delete the subnet
Delete the route tables
Delete the Internet Gateway
Delete the VPC

tariq1890
tariq1890 reviewed Dec 20, 2024
View reviewed changes
scripts/awscleanup.sh Outdated Show resolved Hide resolved
@tariq1890
Copy link
Contributor

@shivakunv Please amend the commit and retitle the PR as follows

Add script to clean-up unused AWS EC2 Instances and VPCs"

@shivakunv shivakunv changed the title unused aws instace and vpcs cleanup Add script to clean-up unused AWS EC2 Instances and VPCs Dec 20, 2024
@shivakunv
Copy link
Contributor Author

Thanks @tariq1890 for reviewing.
incorporated the review comments. PTAL

passed pipeline:-
https://github.com/NVIDIA/holodeck/actions/runs/12427716870/job/34698013023

ArangoGutierrez
ArangoGutierrez requested changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, just a couple nits

.github/workflows/awscleanup.yaml Outdated Show resolved Hide resolved
.github/workflows/awscleanup.yaml Outdated Show resolved Hide resolved
@shivakunv shivakunv mentioned this pull request Jan 7, 2025
Closed
ArangoGutierrez
ArangoGutierrez requested changes Jan 7, 2025
View reviewed changes
.github/workflows/awscleanup.yaml Outdated Show resolved Hide resolved
@ArangoGutierrez
Copy link
Collaborator

PING @tariq1890

@tariq1890
Copy link
Contributor

@shivakunv please rebase the PR

@tariq1890
Copy link
Contributor

@ArangoGutierrez This PR is waiting on your approve as you have requested changes previously

@shivakunv
Copy link
Contributor Author

@ArangoGutierrez PTAL

@ArangoGutierrez ArangoGutierrez merged commit 514c360 into main Jan 15, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tariq1890 tariq1890 tariq1890 approved these changes

@ArangoGutierrez ArangoGutierrez ArangoGutierrez approved these changes

@elezar elezar Awaiting requested review from elezar elezar is a code owner

@cdesiniotis cdesiniotis Awaiting requested review from cdesiniotis cdesiniotis is a code owner

Assignees

@shivakunv shivakunv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shivakunv @tariq1890 @ArangoGutierrez