Skip to content

Commit

Permalink
dynamic holodeck ci instance name
Browse files Browse the repository at this point in the history
Signed-off-by: shiva kumar <[email protected]>
  • Loading branch information
shivakunv committed Dec 17, 2024
1 parent 2ccae8f commit abe3ce4
Showing 1 changed file with 7 additions and 6 deletions.
13 changes: 7 additions & 6 deletions pkg/provider/aws/create.go
Original file line number Diff line number Diff line change
Expand Up @@ -322,12 +322,6 @@ func (p *Provider) createEC2Instance(cache *AWS) error {
cache.SecurityGroupid,
},
SubnetId: aws.String(cache.Subnetid),
TagSpecifications: []types.TagSpecification{
{
ResourceType: types.ResourceTypeNetworkInterface,
Tags: p.Tags,
},
},
},
},
KeyName: aws.String(p.Spec.Auth.KeyName),
Expand All @@ -345,6 +339,13 @@ func (p *Provider) createEC2Instance(cache *AWS) error {
}
cache.Instanceid = *instanceOut.Instances[0].InstanceId

// tag network interface
networkInterfaceId := *instance.NetworkInterfaces[0].NetworkInterfaceId

Check failure on line 343 in pkg/provider/aws/create.go

View workflow job for this annotation

GitHub Actions / build

undefined: instance
_, _ := p.ec2.CreateTags(context.TODO(), &ec2.CreateTagsInput{

Check failure on line 344 in pkg/provider/aws/create.go

View workflow job for this annotation

GitHub Actions / build

no new variables on left side of :=
Resources: []string{networkInterfaceId},
Tags: p.Tags,
})

waiterOptions := []func(*ec2.InstanceRunningWaiterOptions){
func(o *ec2.InstanceRunningWaiterOptions) {
o.MaxDelay = 1 * time.Minute
Expand Down

0 comments on commit abe3ce4

Please sign in to comment.