standardise object hash generation across the repo #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tariq1890
requested review from
ArangoGutierrez,
cdesiniotis,
elezar and
shivamerla
as code owners
Signed-off-by: Tariq Ibrahim <[email protected]>
tariq1890
force-pushed
the
no-hashstructure
branch
from
d7a26db to
7068fec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the need for the
mitchellh/hashstructuremodule and sticks to using one hash generator method for the whole project.We are also using an old version of
mitchellh/hashstructureand we'd be better off with lesser module imports in general