Create driver-ready file atomically #789
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evan Lezar <[email protected]>
elezar
requested review from
ArangoGutierrez,
cdesiniotis,
shivamerla and
tariq1890
as code owners
elezar
force-pushed
the
create-driver-ready-atomically
branch
from
5e5d0fd to
afdea8f
Compare
tariq1890
reviewed
Jun 27, 2024
|
|
||
| if err := os.Rename(tmpFile.Name(), statusFile); err != nil { | ||
| return fmt.Errorf("error moving temporary file to '%v': %w", statusFile, err) |
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("error moving temporary file to '%v': %w", statusFile, err) | |
| return fmt.Errorf("error moving temporary file to '%s': %w", statusFile, err) |
There was a problem hiding this comment.
I have address this comment in #790
|
Moving to #790 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that the
driver-readyfile is created atomically. This prevents operands from loading an empty file and not applying the relevant settings.