add ngc signing job for auto signing #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivakunv
requested review from
ArangoGutierrez,
cdesiniotis,
elezar,
shivamerla and
tariq1890
as code owners
|
@cdesiniotis @elezar PTAL |
shivakunv
force-pushed
the
ngc_signing_job
branch
6 times, most recently
from
d57687d to
fa4871c
Compare
cdesiniotis
reviewed
Jun 12, 2024
There was a problem hiding this comment.
@shivakunv For both the gpu-operator and gpu-operator-validator images, we push a short tag and a tag with the ubi8 suffix. I left some suggestions so that we sign both tags now. These changes align with the changes you made in the other projects.
shivakunv
force-pushed
the
ngc_signing_job
branch
2 times, most recently
from
c90b88c to
5b98069
Compare
|
@cdesiniotis resolved all comments PTAL |
Signed-off-by: shiva kumar <[email protected]>
shivakunv
force-pushed
the
ngc_signing_job
branch
from
5b98069 to
19a4889
Compare
cdesiniotis
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Thanks for making this contribution! When contributing to this repository please keep in mind the following: