Skip to content

Commit

Permalink
Merge pull request #760 from NVIDIA/add-dependabot
Browse files Browse the repository at this point in the history
Add dependabot config
  • Loading branch information
elezar authored Jun 14, 2024
2 parents 2ec640d + 5e8988e commit 24949e0
Show file tree
Hide file tree
Showing 6 changed files with 40 additions and 21 deletions.
36 changes: 36 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
# Please see the documentation for all configuration options:
# https://docs.github.com/github/administering-a-repository/configuration-options-for-dependency-updates

version: 2
updates:
- package-ecosystem: "gomod"
target-branch: main
directory: "/"
schedule:
interval: "weekly"
day: "sunday"
labels:
- dependencies
groups:
k8sio:
patterns:
- k8s.io/*
exclude-patterns:
- k8s.io/klog/*

# Update GPU Operator base images.
- package-ecosystem: "docker"
directory: "/docker"
schedule:
interval: "daily"

# Update GPU Operator Validator base images.
- package-ecosystem: "docker"
directory: "/validator"
schedule:
interval: "daily"

- package-ecosystem: "github-actions"
directory: "/"
schedule:
interval: "daily"
4 changes: 0 additions & 4 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ endif
include $(CURDIR)/versions.mk

MODULE := github.com/NVIDIA/gpu-operator
CUDA_IMAGE ?= nvcr.io/nvidia/cuda
BUILDER_IMAGE ?= golang:$(GOLANG_VERSION)
DIST ?= ubi8

Expand Down Expand Up @@ -295,9 +294,6 @@ $(BUILD_TARGETS): build-%:
$(DOCKER_BUILD_OPTIONS) \
$(DOCKER_BUILD_PLATFORM_OPTIONS) \
--tag $(IMAGE) \
--build-arg BASE_DIST="$(DIST)" \
--build-arg CUDA_IMAGE="$(CUDA_IMAGE)" \
--build-arg CUDA_VERSION="$(CUDA_VERSION)" \
--build-arg VERSION="$(VERSION)" \
--build-arg BUILDER_IMAGE="$(BUILDER_IMAGE)" \
--build-arg GOLANG_VERSION="$(GOLANG_VERSION)" \
Expand Down
8 changes: 2 additions & 6 deletions docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,9 @@
# See the License for the specific language governing permissions and
# limitations under the License.

ARG CUDA_IMAGE=nvcr.io/nvidia/cuda
ARG CUDA_VERSION=undefined

ARG BASE_DIST=ubi8
ARG GOLANG_VERSION=x.x.x

FROM ${CUDA_IMAGE}:${CUDA_VERSION}-base-${BASE_DIST} as builder
FROM nvcr.io/nvidia/cuda:12.4.1-base-ubi8 as builder

RUN yum install -y wget make git gcc

Expand Down Expand Up @@ -59,7 +55,7 @@ ARG VERSION="unknown"
ARG GIT_COMMIT="unknown"
RUN make gpu-operator

FROM ${CUDA_IMAGE}:${CUDA_VERSION}-base-${BASE_DIST}
FROM nvcr.io/nvidia/cuda:12.4.1-base-ubi8

# Remove CUDA libs(compat etc) in favor of libs installed by the NVIDIA driver
RUN dnf remove -y cuda-*
Expand Down
8 changes: 2 additions & 6 deletions validator/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,10 @@
# See the License for the specific language governing permissions and
# limitations under the License.

ARG CUDA_IMAGE=nvcr.io/nvidia/cuda
ARG CUDA_VERSION=undefined
ARG CUDA_SAMPLE_IMAGE=undefined

ARG BASE_DIST=ubi8
ARG GOLANG_VERSION=x.x.x

FROM ${CUDA_IMAGE}:${CUDA_VERSION}-base-${BASE_DIST} as build
FROM nvcr.io/nvidia/cuda:12.4.1-base-ubi8 as build

RUN yum install -y wget make git gcc

Expand Down Expand Up @@ -55,7 +51,7 @@ FROM ${CUDA_SAMPLE_IMAGE} AS sample-builder
RUN mkdir /artifacts
RUN cp /cuda-samples/vectorAdd /artifacts/vectorAdd

FROM ${CUDA_IMAGE}:${CUDA_VERSION}-base-${BASE_DIST}
FROM nvcr.io/nvidia/cuda:12.4.1-base-ubi8

# Remove CUDA libs(compat etc) in favor of libs installed by the NVIDIA driver
RUN dnf remove -y cuda-*
Expand Down
4 changes: 0 additions & 4 deletions validator/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ endif
##### Global variables #####
include $(CURDIR)/versions.mk

CUDA_IMAGE ?= nvcr.io/nvidia/cuda
BUILDER_IMAGE ?= golang:$(GOLANG_VERSION)

ifeq ($(IMAGE_NAME),)
Expand Down Expand Up @@ -85,9 +84,6 @@ $(BUILD_TARGETS): build-%:
$(DOCKER_BUILD_OPTIONS) \
$(DOCKER_BUILD_PLATFORM_OPTIONS) \
--tag $(IMAGE) \
--build-arg BASE_DIST="$(DIST)" \
--build-arg CUDA_IMAGE="$(CUDA_IMAGE)" \
--build-arg CUDA_VERSION="$(CUDA_VERSION)" \
--build-arg VERSION="$(VERSION)" \
--build-arg GIT_COMMIT="$(GIT_COMMIT)" \
--build-arg BUILDER_IMAGE="$(BUILDER_IMAGE)" \
Expand Down
1 change: 0 additions & 1 deletion versions.mk
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
# - use environment variables to overwrite this value (e.g export VERSION=0.0.2)
VERSION ?= v24.3.0

CUDA_VERSION ?= 12.4.1
GOLANG_VERSION ?= 1.22.2

GIT_COMMIT ?= $(shell git describe --match="" --dirty --long --always 2> /dev/null || echo "")

0 comments on commit 24949e0

Please sign in to comment.