Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added --export-dynamic linker flag for go 1.21 support #47

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Added --export-dynamic linker flag for go 1.21 support #47

merged 1 commit into from
Dec 4, 2023

Conversation

nvvfedorov
Copy link
Collaborator

When built with go1.21.x, go-dcgm panics. This happens because of the changes in the go1.21.x behavior in the linker. A similar issue was found and fixed in the go-nvml NVIDIA/go-nvml#79.

The PR was tested in the following way:

  1. Use go1.18.x and run make binaries.
  2. Execute binaries located in the ./samples directory.

Expected behavior: no errors.

  1. Switch the environment to use go1.21.x, run make clean and make binaries
  2. Execute binaries located in the ./samples directory.

Expected behavior: no errors. Before the change, the error was:

SIGSEGV: segmentation violation
PC=0x0 m=0 sigcode=1
signal arrived during cgo execution

@nikkon-dev nikkon-dev marked this pull request as ready for review December 4, 2023 19:54
@nvvfedorov nvvfedorov merged commit 025bc2f into main Dec 4, 2023
1 check passed
@nvvfedorov nvvfedorov deleted the export-dynamic branch December 4, 2023 20:39
@nvvfedorov nvvfedorov mentioned this pull request Jan 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikkon-dev nikkon-dev nikkon-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nvvfedorov @nikkon-dev