Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python build updates for libraries #2554

Closed
wants to merge 1 commit into from

Conversation

bmhowe23
Copy link
Collaborator

Trying to eliminate CUDA-Q customizations required to build CUDA-QX libraries.

Original author: @boschmitt

Ref: https://github.com/NVIDIA/cudaqx/blob/c30376311bd15c1ec70933f2ad591ce5898da00e/.github/workflows/scripts/build_cudaq.sh#L96

@@ -17,6 +17,6 @@ if (SKBUILD)
if (NOT Python_FOUND)
message(FATAL_ERROR "find_package(Python) not run?")
endif()
target_link_libraries(cudaq-pyscf PRIVATE Python::Python pybind11::pybind11 cudaq-chemistry cudaq-spin cudaq cudaq-py-utils)
target_link_libraries(cudaq-pyscf PRIVATE Python::Module pybind11::pybind11 cudaq-chemistry cudaq-spin cudaq cudaq-py-utils)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably take this opportunity to mark the cudaq pyscf create_molecule stuff as deprecated in favor of the cuda-qx implementation.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I take it that means this change one line wouldn't be needed then. What about the other one line in this pr?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct - I don't think this change is needed beyond this library, which we need to deprecate anyway.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably take this opportunity to mark the cudaq pyscf create_molecule stuff as deprecated in favor of the cuda-qx implementation.

It is most likely the necessary thing. My solution on CUDA-QX is a hack that breaks other CUDA-Q build scenarios. (As can be seen in the pipelines here.)

@bmhowe23 bmhowe23 closed this Jan 29, 2025
@bmhowe23 bmhowe23 deleted the pr-update-build-process branch January 29, 2025 15:19
github-actions bot pushed a commit that referenced this pull request Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants