Skip to content

Commit

Permalink
Merge branch 'backport-for-23.6.2' into 'master'
Browse files Browse the repository at this point in the history
Patch release to backport fix for Argo CD deps

See merge request nvidia/cloud-native/cnt-docs!362
  • Loading branch information
mikemckiernan committed Dec 14, 2023
2 parents d197736 + 1de6072 commit 5c6be07
Show file tree
Hide file tree
Showing 2 changed files with 33 additions and 1 deletion.
31 changes: 30 additions & 1 deletion gpu-operator/release-notes.rst
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,15 @@ Fixed issues
Refer to GitHub `issue #602 <https://github.com/NVIDIA/gpu-operator/issues/602>`_ for more details.

* Previously, when you specified the ``operator.upgradeCRD=true`` argument to the ``helm upgrade``
command, the pre-upgrade hook ran with the ``gpu-operator`` service account.
command, the pre-upgrade hook ran with the ``gpu-operator`` service account
that is added by running ``helm install``.
This dependency is a known issue for Argo CD users.
Argo CD treats pre-install and pre-upgrade hooks the same as pre-sync hooks and leads to failures
because the hook depends on the ``gpu-operator`` service account that does not exist on an initial installation.

Now, the Operator is enhanced to run the hook with a new service account, ``gpu-operator-upgrade-crd-hook-sa``.
This fix creates the new service account, a new cluster role, and a new cluster role binding.
The update prevents failures with Argo CD.

* Previously, duplicate image pull secrets were added to some daemon sets and caused an error
like the following when a node is deleted and the controller manager deleted the pods.
Expand Down Expand Up @@ -278,6 +284,29 @@ Known Limitations
Additionally, network-restricted environments are not supported.


.. _v23.6.2:

23.6.2
======

This patch release back ports a fix that was introduced in the v23.9.1 release.

.. _v23.6.2-fixed-issues:

Fixed Issues
------------

* Previously, when you specified the ``operator.upgradeCRD=true`` argument to the ``helm upgrade``
command, the pre-upgrade hook ran with the ``gpu-operator`` service account
that is added by running ``helm install``.
This dependency is a known issue for Argo CD users.
Argo CD treats pre-install and pre-upgrade hooks the same as pre-sync hooks and leads to failures
because the hook depends on the ``gpu-operator`` service account that does not exist on an initial installation.

Now, the Operator is enhanced to run the hook with a new service account, ``gpu-operator-upgrade-crd-hook-sa``.
This fix creates the new service account, a new cluster role, and a new cluster role binding.
The update prevents failures with Argo CD.

23.6.1
======

Expand Down
3 changes: 3 additions & 0 deletions gpu-operator/versions.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@
{
"version": "23.9.0"
},
{
"version": "23.6.2"
},
{
"version": "23.6.1"
},
Expand Down

0 comments on commit 5c6be07

Please sign in to comment.