Add infrastructure for passing in external forecasts #44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds capabilities to the
HerculesADInterface
andHerculesHybridADInterface
so that forecasts can be included in the received measurements. These come through the "external_signals" channel of the Hercules dictionary, which are in turn read in from a csv file.To demonstrate the behavior, I've also updated the tests, and added a mock controller
HybridSupervisoryControllerBaseline_ForecastDemo
that takes the same control action asHybridSupervisoryControllerBaseline
but also prints out any received forecasts. The idea is that an as-yet-undeveloped controller needs to receive forecasts, this will be the template.Before merger, this
_ForecastDemo
controller will be removed or replaced with something more functional.I am yet to develop an example that fully shows the new capability, but I will try to add that in the coming days.
@genevievestarke , @christiannvaughn , @paulf81 just tagging you here so that you see developments.