-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up examples directory #42
Conversation
Addresses #38 |
@genevievestarke I've lengthened the simple_hybrid_plant/ simulation from 1 minute to 5 minutes to get through transients and demonstrate more "steady-state" behavior (although disturbances continue to be varying). |
@genevievestarke @paulf81 I've requested a review from both of you---it would be great if at least one of you could pull this down and run the example (using Feel free to look over the documentation updates, but no need to try to build them---I've been able to build them locally without issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The wind plotting for this example is a little weird. It looks like only one turbine is below the others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may just be that all of the turbines are experiencing very similar wind conditions with minimal waking. Let me know what you find, and if it seems like something is off I'm happy to help dig into it
I pulled it down and ran all the examples, and they look good. Just a little weird on the wind in the simple hybrid case. I'll look into it |
@misi9170 I pulled this down and all 3 examples worked for me and the plots showed up when I ran using the current Develop branch of Hercules. Let me know if you want to work together in bringing over the more bash_script heavy version being set up here NREL/hercules#133, over to this WHOC PR |
Thanks @paulf81 , @genevievestarke . @paulf81 --- Having the bash scripts could be good, but less important than over on Hercules I think. I'd say let's see how they go on Hercules first, and can possibly port them over in future. @genevievestarke , you probably haven't yet had a chance to look into the wind turbine powers in the simple_hybrid_plant/ yet. I'll take a quick look today to see if I see anything wayward and let you know |
@misi9170 Thank you for looking into this, these plots are great!! Ok, that all makes sense to me, just a little surprised that none of the other turbines are waked! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! The only thing I would comment on is if the hercules_input.yaml should be in the inputs folder?
Also, I ran all examples and tests!
Fair point---having the hercules_input.yaml outside of the inputs/ subdirectory is consistent with how the examples are organized in Hercules. However, for WHOC (where the Hercules input is not the main focus), I agree that it makes sense to put the hercules_input.yaml into the inputs/ subdirectory. |
Following a similar procedure on Hercules, this PR aims to clean up the available examples in WHOC and make them simpler to run.
This will stay as a draft PR while I work through the list below.
NOTE: Need to be on the develop branch of Hercules currently
lookup-based_wake_steering_florisstandin/ (on hold while I develop other wake steering capabilities in WHOC)
simple_hybrid_plant/
wind_farm_power_tracking_florisstandin/