Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All meta data in pyproject.toml #41

Merged
merged 3 commits into from
Nov 19, 2024
Merged

All meta data in pyproject.toml #41

merged 3 commits into from
Nov 19, 2024

Conversation

paulf81
Copy link
Collaborator

@paulf81 paulf81 commented Nov 13, 2024

Move all metadata to pyproject.toml

Following examples such as:

https://packaging.python.org/en/latest/guides/modernize-setup-py-project/

This PR moves all metadata into pyproject.toml. Specifically:

  • All metadata now in pyproject.toml
  • setup.py and version.py deleted
  • References to setup.py and version.py updated according to guide above

@paulf81 paulf81 added the enhancement New feature or request label Nov 13, 2024
@paulf81 paulf81 requested a review from misi9170 November 13, 2024 21:59
@paulf81 paulf81 self-assigned this Nov 13, 2024
misi9170
misi9170 approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@misi9170 misi9170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @paulf81 ! Was able to install WHOC in a new environment with this and tests all ran fine

@paulf81
Copy link
Collaborator Author

paulf81 commented Nov 19, 2024

Great!

@misi9170 misi9170 merged commit bae938a into develop Nov 19, 2024
6 checks passed
@misi9170 misi9170 deleted the feature/pyproj branch November 19, 2024 16:26
@misi9170 misi9170 mentioned this pull request Nov 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misi9170 misi9170 misi9170 approved these changes

Assignees

@paulf81 paulf81

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulf81 @misi9170