-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add baseline supervisory hybrid plant controller #36
Merged
misi9170
merged 31 commits into
NREL:develop
from
misi9170:feature/supervisory-skeleton
Jul 26, 2024
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
795ba83
Skeleton hybrid supervisory controller.
misi9170 42e4994
passthrough controllers for solar and battery.
misi9170 5b02526
hybrid interface added; bugfixes.
misi9170 b6324df
print statements, bug fixes.
misi9170 761346f
Solar now runs as expected, with some mods on hercules.
misi9170 b173cf1
Add example files.
misi9170 5d58a19
Ruff.
misi9170 ca3b10e
Add other necessary measurements for supervisory control.
misi9170 295ef7a
Add interface test.
misi9170 1e50219
Full tests for interface; basic test for contorller.
misi9170 7492e1b
Get reference in supervisory_control stand in.
misi9170 f65ae8c
Fix copy-paste error.
misi9170 537ffd9
Add documentation.
misi9170 40da443
Add simple hybrid controller
genevievestarke e25722a
Updating basic hybrid controller
genevievestarke 2a4bc1c
Fix Ruff formatting
genevievestarke cbcd6af
Fix Ruff lines that are too long
genevievestarke d8ca92f
Fix Ruff take 3
genevievestarke 3c377f0
Removing farm capacity definition from WHOC
genevievestarke eef9d2d
Fixing bug for when SOC is maxed out
genevievestarke a767a53
Merge pull request #1 from genevievestarke/feature/simple_hybrid_cont…
misi9170 4b41285
Remove rate setpoint from interface and instead pass directly to inst…
misi9170 f27dc41
Rename skeleton controller to baseline.
misi9170 84113c6
Update baseline controller description
genevievestarke 71a80a9
Adding working hybrid plant example
genevievestarke 593817c
Fixing ruff call from update
genevievestarke f1c8612
Fix ruff formatting
genevievestarke fc2c100
Clean up output notebook
genevievestarke 74fbbeb
Add headings to example.
misi9170 73aab54
Import sorting.
misi9170 d91c41e
Update controller description
genevievestarke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,7 +25,7 @@ jobs: | |
# - uses: pre-commit/[email protected] | ||
- name: Run ruff | ||
run: | | ||
ruff . | ||
ruff check . | ||
ruff format | ||
- name: Run tests and collect coverage | ||
run: | | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@genevievestarke could you check the documentation below and see if I've accurately portrayed the
HybridSupervisoryControllerBaseline
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the description, let me know if it makes sense!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@genevievestarke , just bumping this, are you OK with the description I've written for the
HybridSupervisoryControllerBaseline
? Feel free to update the description if you'd like.