Updating WHOC/HERCULES communication to fix logging issue. #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
March 26, 2024 13:08
misi9170
approved these changes
Mar 28, 2024
genevievestarke
approved these changes
Mar 28, 2024
achenry
pushed a commit
to achenry/wind-hybrid-open-controller
that referenced
this pull request
Apr 22, 2024
* hercules_wind_battery_controller test * minor fix for WHOC/HERCULES battery signal exchange * WHOC/HERCULES battery signal communication update * delete erroneous merge tokens * update tests to reflect new WHOC/HERCULES communication * delete log file --------- Co-authored-by: Zachary <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hercules was not writing outputs correctly because the WHOC
WindBatteryControllerwas adding entries to the main dictionary after the first loop. I updated the wayhercules_wind_battery_interfaceassigns control signals to the output dictionary to fix the Hercules logging issue.