Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize ground clearance height for IEC module model #1194

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Initialize ground clearance height for IEC module model #1194

merged 1 commit into from
Jul 30, 2024

Conversation

brtietz
Copy link
Collaborator

@brtietz brtietz commented Jul 29, 2024

Fixes #1190

Should be good to go if SSC tests pass

@brtietz brtietz added bug pv photovoltaic, pvsam, pvwatts labels Jul 29, 2024
@brtietz brtietz added this to the 2023 Release Patch 2 milestone Jul 29, 2024
@brtietz brtietz requested review from sjanzou and janinefreeman July 29, 2024 22:40
@brtietz brtietz self-assigned this Jul 29, 2024
sjanzou
sjanzou approved these changes Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@sjanzou sjanzou left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this... One of the Windows runners failed - I restarted. This does seem to be a common issue...the windows runner works for the push and then a test fails on the pull request
image

@brtietz brtietz mentioned this pull request Jul 30, 2024
Open
@brtietz
Copy link
Collaborator Author

brtietz commented Jul 30, 2024

Thanks! I've also seen other tests fail intermittently in lib_utility_rate_test, again only on the windows pull runner. I filed #1195 and tagged it for the release since intermittent issues are less urgent and take more time.

@brtietz brtietz merged commit dbe696b into patch Jul 30, 2024
8 checks passed
@brtietz brtietz deleted the ssc_1190 branch December 13, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjanzou sjanzou sjanzou approved these changes

@janinefreeman janinefreeman Awaiting requested review from janinefreeman

Assignees

@brtietz brtietz

Labels
added to release notes bug pv photovoltaic, pvsam, pvwatts
Projects
None yet
Milestone
2023 Release Patch 2
Development

Successfully merging this pull request may close these issues.

Windows test timeout in lib_irradproc.cpp
3 participants
@brtietz @sjanzou @cpaulgilman