Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

break space update #1340

Merged
merged 5 commits into from
Jan 29, 2025
Merged

break space update #1340

merged 5 commits into from
Jan 29, 2025

Conversation

yingli-NREL
Copy link

Pull Request Description

  1. update the breaker space distribution csv table
  2. add building type and floor area as dependent variables

@yingli-NREL yingli-NREL requested a review from lixiliu January 23, 2025 00:12
lixiliu
lixiliu approved these changes Jan 25, 2025
View reviewed changes
Copy link
Contributor

@lixiliu lixiliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Yingli. Merge when all CI tests passed.

@lixiliu lixiliu merged commit 0d36268 into ll/test_panel_cap Jan 29, 2025
@lixiliu lixiliu deleted the ll/test_panel_cap_break_space_update branch January 29, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lixiliu lixiliu lixiliu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yingli-NREL @lixiliu