Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix an error in the secondary school geometry file #1144

Merged
merged 10 commits into from
Jul 30, 2021

Conversation

yunyangye
Copy link
Collaborator

Fix the issue posted in #1132 .

@yunyangye yunyangye requested a review from lymereJ July 16, 2021 21:30
@yunyangye yunyangye linked an issue Jul 16, 2021 that may be closed by this pull request
@lymereJ lymereJ requested a review from mdahlhausen July 16, 2021 22:06
@lymereJ lymereJ added the OS Prototypes Improvements to the OS prototype models. label Jul 16, 2021
@mdahlhausen
Copy link
Collaborator

Update the regression tests with OS 3.0; the OS 3.2 tests will fail (for now). If the older version regression tests pass, I'll merge this.

Copy link
Collaborator

@mdahlhausen mdahlhausen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-generate regression model in OS 3.0

mdahlhausen and others added 8 commits July 27, 2021 11:29
@yunyangye yunyangye requested review from lymereJ and mdahlhausen July 28, 2021 23:27
Copy link
Collaborator

@mdahlhausen mdahlhausen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regression tests still failing

@yunyangye yunyangye requested a review from mdahlhausen July 30, 2021 21:50
@mdahlhausen mdahlhausen merged commit 784fadd into master Jul 30, 2021
@mdahlhausen mdahlhausen deleted the pnnl_fix_secondaryschool_geometry branch July 30, 2021 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS Prototypes Improvements to the OS prototype models.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SecondarySchool geometry has an orphan sub-surface in it
4 participants