Adjacent test and fix #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had tested this argument in a number of tests, but neglected to do it in one of the tests that also run create_typical. I currently only run create_typical on subset of tests but maybe should extend them all to do this.
having issue with second bar being all adiabatic even after these changes
Also added info now as indication fo failed match attempt. Would have done warning but don't to trigger errors on a lot of tests that count warnings.
mdahlhausen
approved these changes
Oct 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted new adiabatic wall code to first try and intersect and match walls, and only switch to adiabatic when necessary. When a non-match is found an info statement is made, but I may change that to a warning, but didn't want to have to update tests that count warnings.