add measure for SimulationControl #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we are going to add this need at least a test.rb file and a measure.xml |
|
@MatthewSteen If Autodesk is going to use that and we needed in installer we can try to get this added in the next day or two |
|
This is still a WIP that's not ready for review yet so I plan to add the files when I get back to it. This is a longer term effort, so doesn't need to be in the next release, thanks. |
|
@DavidGoldwasser this is ready for a review. |
1 similar comment
|
@DavidGoldwasser this is ready for a review. |
MatthewSteen
force-pushed
the
add/simulation_control
branch
from
40c6d20 to
d43de2f
Compare
|
@DavidGoldwasser this is ready for review. Test failure looks unrelated. Please add this to 0.10.0 if possible. |
DavidGoldwasser
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a measure for the
SimulationControlclass, which was originally written in https://github.com/NREL/gbxml-to-openstudio/tree/193e50dfaa4f55ac9d9670a3821c374e88f04d0e/measures/set_simulation_control.