-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update installation instructions #132
Open
paulf81
wants to merge
65
commits into
NREL:develop
Choose a base branch
from
paulf81:feature/update_install
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 64 commits
Commits
Show all changes
65 commits
Select commit
Hold shift + click to select a range
7482bb3
Rename readme
paulf81 9d67279
readme to md
paulf81 bc3580d
Clean up run scripts
paulf81 9ce83d2
Merge branch 'develop' into feature/standard_example
paulf81 50e1f6c
Remove example 2
paulf81 6bc5a84
update runscript and readme
paulf81 7f0009b
Update readmes
paulf81 61400c4
Update run script
paulf81 a0e6736
update readme and runscript
paulf81 e5ffd78
update run scripts
paulf81 685dbd7
re-org example 7
paulf81 4d72ff9
rename example 5
paulf81 1ce747e
rename example 8
paulf81 b766429
set sim to 20 s
paulf81 15ea201
Update output vis
paulf81 046b28e
move amr_input
paulf81 4d843f4
delete unnecessary rm
paulf81 f1329d3
update README
paulf81 d8cccf8
temp move amr-openfast to be adjacent to amr cases
paulf81 fccf59a
update readme and runscript
paulf81 7d75b0d
organize inputs
paulf81 f1a7ffc
reinclude input csv
paulf81 d93f9bb
Updating electrolyzer example to work with electrolyzer develop branch
genevievestarke 3650720
changing generate_amr_wind_standin_data to work with the other standi…
afb4db8
Merge branch 'develop' into feature/standard_example
misi9170 2e16b76
Add back input data for example 10.
misi9170 d6c84b2
Fix issues with example 10 (mainly, enable power return from either S…
misi9170 773b6eb
Add plot outputs
paulf81 08864c9
remove all python 3
paulf81 0fd0d95
Update run_script
paulf81 adcab20
Update outputs
paulf81 1eed659
long line
paulf81 63937c3
ruff
paulf81 8269df5
Update example 01
paulf81 ea85de7
Update Example 05 README
genevievestarke 44d4870
Update example 06 run_script to generate standin data and output dire…
80ca2bd
Change emulator.py to not call py_sims.step when there are no py_sims…
0367082
Copied solar_pysam_test.py input file to test_inputs folder instead o…
cff75b9
Renumber AMR examples
paulf81 d7c6a15
Update 06 outputs
paulf81 67a423b
Try editing batch
paulf81 1503bd8
Add helics killer
paulf81 1058576
Update kestrel run scripts
paulf81 dcdc062
Merge branch 'develop' into feature/standard_example
misi9170 b774b40
trimmed the input solar file so that DNI > 900 MW so that solar power…
brookeslawski 4521c13
Merge branch 'feature/standard_example' of github.com:NREL/hercules i…
brookeslawski 5a8cd07
Update yaml input file headers
genevievestarke 8868428
Merge branch 'develop' into feature/standard_example
misi9170 071a7a8
Move port to 32010
paulf81 b8b7aaa
Add kill script link
paulf81 5f338a4
Add plot script
paulf81 b0f2445
Rename dir 10
paulf81 5b5aad4
update readme names
paulf81 3e4daa5
Update example refs in docs
paulf81 af1da04
ignore doc builds
paulf81 fbe256a
Update README titles
paulf81 f55723a
Add .log extensions to logfiles, remove unused batch_script from 06 e…
misi9170 506e4d8
Reinclude data file for 07 example.
misi9170 0d62ba3
adding solar input csv file for example 07
brookeslawski 89fe6d4
Change to run_script
misi9170 4d53a84
Reinstate 06 example batch_script.sh
misi9170 b07835a
remove check examples workflow
paulf81 9f055e3
Update SEAS reference
paulf81 6e380cf
Merge branch 'develop' into feature/update_install
paulf81 150949a
Update to local running instructions
genevievestarke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,7 +23,7 @@ jobs: | |
python -m pip install --upgrade pip | ||
pip install -e ".[develop]" | ||
pip install git+https://github.com/NREL/electrolyzer.git@develop | ||
pip install https://github.com/NREL/SEAS/blob/main/SEAS.tar.gz?raw=true | ||
pip install https://github.com/NREL/SEAS/blob/v1/SEAS.tar.gz?raw=true | ||
# - uses: pre-commit/[email protected] | ||
- name: Run ruff | ||
run: | | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't actually comment on the lines below this, because this PR doesn't change them, but they seem to assume the user has already declared a
HELICS_PORT
variable?Also, hercules_runscript_dummy_amr.py doesn't exist anymore (should be some sort of florisstandin runscript)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'm not positive about this whole section. In the same way as the runscript in each folder might be a little different, the manual version might also be a little different and the best approach would be just to enter the lines appearing in the runscript as they appear. Possibly in 3 terminals, or using the & to unblock, maybe just shorten this section to something more like "to be sure, it's possible to enter the commands in the runscript directly..."?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense to encourage people to use the run_script.sh . So, perhaps those instructions should come first. But then, maybe it is worth taking the example of one of the run_script.sh , and talking through what each line is doing (and explain that it is possible to run this from three separate terminals, if that's what the user would prefer to do)?