Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add init calls in from_*methods #59

Closed
wants to merge 1 commit into from
Closed

Conversation

kylecarow
Copy link
Collaborator

No description provided.

@kylecarow kylecarow requested a review from calbaker October 20, 2023 19:50
@kylecarow kylecarow marked this pull request as draft November 22, 2023 21:59
@calbaker
Copy link
Collaborator

@kylecarow , is this still needed?

@kylecarow
Copy link
Collaborator Author

@kylecarow , is this still needed?

For fastsim-2 it's still needed, yeah

@kylecarow kylecarow closed this Dec 18, 2023
@kylecarow kylecarow deleted the from_method_inits branch January 4, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants