Fix issues encountered during pytest #166
Conversation
This updates the `build_and_test.yaml` file to also build source distributions (sdist), wheel files, and to also save artifacts of those builds.
We updated the python versions to be the full version (e.g., 3.8, 3.9, or 3.10) versus just the minor version (e.g., 8, 9, 10). However, the string replacement code was not updated appropriately that got copied over for cibuildwheel. This has been corrected.
This makes the string manipulation easier for cibuildwheel.
Note: this is to get around issues encountered on CI using delocate-wheel which is failing.
Python 3.10 and 3.11 are being tested on the CI. This bumps the minimum range up to 3.10 from 3.8. Note: as of today, 3.8 is end-of-life.
Try setting the MACOS_DEPLOYMENT_TARGET equal to 10.12 per instructions from failed pipeline.
| - base: ubuntu | ||
| version: latest | ||
| - base: macos | ||
| version: '13' |
There was a problem hiding this comment.
@michael-okeefe , could you drop some comments in here explaining why latest does not work for macos and why 13 and 14 are used here? I want to make sure this is not hard to decipher in the future.
There was a problem hiding this comment.
@michael-okeefe , please also explain in the comments what event should trigger adding 15, 16, ...
There was a problem hiding this comment.
Sure, I can do that. The issue is related to what processor each github CI machine is running for mac. MacOS 13 is Intel and MacOS 14 is Apple Silicon. Ideally, the Apple transition to their new chip occurs fast and we can drop having to call out specific machines and then just use latest, etc. 15, 16, etc. can be brought in at any time we desire and they should look like the calls for 14. As soon as 13 drops from the board, we can go back to just saying 'latest'.
There was a problem hiding this comment.
@calbaker Note added to clarify why we are calling out macos-13 and 14.
|
@calbaker Apologies, I must have gotten my PRs mixed up as I don't see the change here, either. This was the area where the issue occurred during tests: Not sure if this is the exact line or not, though. |
The Mac OS options might be hard for others to follow. Here, we add a note to help others following behind to understand what we're doing and why.
| @@ -7,6 +7,9 @@ jobs: | |||
| name: build py3.${{ matrix.python-version }} on ${{ matrix.platform || matrix.os.base }}-${{ matrix.os.version }} | |||
| strategy: | |||
| fail-fast: true | |||
| # NOTE: In the matrix below, we call out macos 13 and 14 explicitly. This is to enable running on both Intel and Apple Silicon for Mac. | |||
| # As of this writing, MacOS 13 is Intel and MacOS 14 is Apple Silicon. Ideally, the Apple transition to their new chip occurs fast and | |||
| # we can drop macos-13 checks and then just use 'latest'. | |||
There was a problem hiding this comment.
@michael-okeefe , could we use 13 and latest so that we don't have to remember to increment the 14?
There was a problem hiding this comment.
@calbaker Great idea. I made the change and the tests are running.
Fixes some issues encountered during running
pytest -von Windows:Additionally, this version adds a CI workflow file to build and test the application.