Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some more real home test files #706

Merged
merged 6 commits into from
Jan 13, 2024
Merged

Add some more real home test files #706

merged 6 commits into from
Jan 13, 2024

Conversation

shorowit
Copy link
Collaborator

@shorowit shorowit commented Jan 12, 2024

Pull Request Description

Also fixes a possible 301ruleset.rb error due to floating point arithmetic. Should be a rare occurrence.

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

  • OS-HPXML git subtree has been pulled
  • 301/ES rulesets and unit tests have been updated
  • 301validator.xml has been updated (reference EPvalidator.xml)
  • Workflow tests have been updated
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected regression test changes on CI

@shorowit shorowit self-assigned this Jan 12, 2024
@shorowit shorowit merged commit 47871e7 into master Jan 13, 2024
@shorowit shorowit deleted the more_real_homes branch January 13, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant