Update jupyter examples for HOPP 3.1.1 #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakotaramos
approved these changes
Jan 23, 2025
johnjasa
approved these changes
Jan 23, 2025
RHammond2
pushed a commit
that referenced
this pull request
Feb 4, 2025
RHammond2
added a commit
that referenced
this pull request
Feb 4, 2025
* Merge patches in `main` into `develop` (#41) * Enhancement: Update issue and PR templates (#35) * fix bad merge conflict resolution from ad7d7c8 (#40) * Add dependency: CoolProp (#42) * Bugfix: correct LCOE units in OpenMDAO HOPP wrapper (#43) * Add `pre-commit` workflow for automated linting and formatting (#57) * Financial update: steel/ammonia plant cost year updated to 2022 and updates to work with HOPP 3.1.1 (#58) * Feedstock transport costs (carbon, lime, iron ore pellet) (#59) * add weighted average financial parameter function (#60) * update MIRR calculation and allow parameter weighting without specifying parameter values for tech with zero-cost technology (i.e. excluded tech) (#73) * update jupyter examples for HOPP 3.1.1 (#76) * LCA Integration (#56) * Create the GH Pages Site and Enable a Documentation CI Pipeline (#78) * bump version for release * Revert "bump version for release" * Add initial new GreenHEART documentation (#72) * Enhancement: Update issue and PR templates (#35)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update jupyter examples for HOPP 3.1.1
This PR provides edits to the financial config files for HOPP used in the Jupyter notebook examples. This changes are required to run with HOPP 3.1.1.
PR Checklist
CHANGELOG.mdhas been updated to describe the changes made in this PRdocs/files are up-to-date, or added when necessaryRelated issues
This PR updates the examples to work with HOPP 3.1.1, which essentially means this is a bug fix to PR #58.
Impacted areas of the software
examples/inputs/plant/default_fin_config.yamlexamples/inputs/plant/greenheart_config_onshore-ammonia.yamlexamples/inputs/plant/greenheart_config_onshore-hydrogen.yamlexamples/inputs/plant/greenheart_config_onshore-steel.yamlAdditional supporting information
The need for this update was brought up while @dakotaramos was working on #56
Test results, if applicable