Added new tag in unity tag manager (https://docs.unity3d.com/410/Docu…

…mentation/Components/class-TagManager.html) to ensure components on new page or cleaned up correctly when leaving the page.
NPBruce · Apr 4, 2024 · bdece9f · bdece9f
1 parent 1d9a598
commit bdece9f
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 6 deletions.
diff --git a/unity/Assets/Scripts/Destroyer.cs b/unity/Assets/Scripts/Destroyer.cs
@@ -37,6 +37,14 @@ public static void Destroy()
         foreach (GameObject go in GameObject.FindGameObjectsWithTag(Game.QUESTLIST))
             Object.Destroy(go);
 
+        // Clean up everything marked as 'contentpackui'
+        foreach (GameObject go in GameObject.FindGameObjectsWithTag(Game.CONTENTPACKUI))
+            Object.Destroy(go);
+
+        // Clean up everything marked as 'contentpacklist'
+        foreach (GameObject go in GameObject.FindGameObjectsWithTag(Game.CONTENTPACKLIST))
+            Object.Destroy(go);
+
         // Clean up everything marked as 'editor'
         foreach (GameObject go in GameObject.FindGameObjectsWithTag(Game.EDITOR))
             Object.Destroy(go);

diff --git a/unity/Assets/Scripts/UI/Screens/ContentSelectDownloadScreen.cs b/unity/Assets/Scripts/UI/Screens/ContentSelectDownloadScreen.cs
@@ -71,6 +71,11 @@ private static void CleanUpDialogs()
             {
                 Destroy(go);
             }
+
+            foreach (GameObject go in GameObject.FindGameObjectsWithTag(Game.CONTENTPACKLIST))
+            {
+                Destroy(go);
+            }
         }
 
         private void DrawContentPackList()
@@ -137,7 +142,6 @@ private void RenderDeleteButton(float offset, KeyValuePair<string, RemoteContent
                 var ui = new UIElement(scrollArea.GetScrollTransform());
                 ui.SetBGColor(Color.clear);
                 ui.SetLocation(UIScaler.GetRight(-6.0f), offset + 1.4f, 1.8f, 1.8f);
-                //TODO Add new image for delete button
                 ui.SetImage(button_no_entry);
                 ui.SetButton(delegate { Delete(contentPack.Value.identifier); });
             }
@@ -233,11 +237,6 @@ private UIElement RenderImage(float offset, KeyValuePair<string, RemoteContentPa
             ui.SetBGColor(Color.clear);
             if (contentPack.Value.image.Length > 0)
             {
-                //if (game.questsList.quest_list_mode != QuestsManager.QuestListMode.ONLINE)
-                //{
-                //    DrawPicture(ContentData.FileToTexture(Path.Combine(contentPack.Value., contentPack.Value.image)), ui); ;
-                //}
-                //else
                 if (images_list.IsImageAvailable(contentPack.Value.package_url + contentPack.Value.image))
                 {
                     DrawPicture(images_list.GetTexture(contentPack.Value.package_url + contentPack.Value.image), ui);

diff --git a/unity/ProjectSettings/TagManager.asset b/unity/ProjectSettings/TagManager.asset
@@ -21,6 +21,8 @@ TagManager:
   - questlist
   - setwindow
   - dialogPart
+  - contentpackui
+  - contentpacklist
   layers:
   - Default
   - TransparentFX