Code

Fix output_root#855

Code

Merged

PhilMiller merged 15 commits intoNOAA-OWP:masterNOAA-OWP/ngen:masterfrom stcui007:output_rootstcui007/ngen:output_rootCopy head branch name to clipboardJul 30, 2024

+32-8

Commits

Commits on Jul 17, 2024

• Fix output_root

  stcui007

  committed
  900a517

  Copy full SHA for 900a517

• Add output_root dir in realization

  stcui007

  committed
  a731e62

  Copy full SHA for a731e62

• Incorporate reviewer's suggestion

  stcui007

  committed
  c829a5b

  Copy full SHA for c829a5b

• Revision after reviewer's comments

  stcui007

  committed
  549628b

  Copy full SHA for 549628b

Commits on Jul 18, 2024

• Using a placeholder output_root dir

  stcui007

  committed
  9fcdbed

  Copy full SHA for 9fcdbed

• Add example_realization_config.json

  stcui007

  committed
  fbfc39c

  Copy full SHA for fbfc39c

Commits on Jul 19, 2024

• Create the directory in code instead of manually

  stcui007

  committed
  ed97ff8

  Copy full SHA for ed97ff8

• Generalize to include the case no output_root in realization

  stcui007

  committed
  79853a8

  Copy full SHA for 79853a8

Commits on Jul 22, 2024

• Remove the modified realization files

  stcui007

  committed
  74160a6

  Copy full SHA for 74160a6

• Add back the realization files w/ or w/o output_root

  stcui007

  committed
  35f90b8

  Copy full SHA for 35f90b8

Commits on Jul 23, 2024

• First pass to address reviewer's comments

  stcui007

  committed
  1342d2b

  Copy full SHA for 1342d2b

• Revise throw message

  stcui007

  committed
  c372080

  Copy full SHA for c372080

• Minor revision

  stcui007

  committed
  14a3798

  Copy full SHA for 14a3798

Commits on Jul 24, 2024

• Change a C to C++ header

  stcui007

  committed
  6b5be12

  Copy full SHA for 6b5be12

• Incorporate reviewer's suggestions

  stcui007

  committed
  f0bd6c7

  Copy full SHA for f0bd6c7