Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message for failure when opening CSV #684

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Improve error message for failure when opening CSV #684

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a0f5eae
Improve error message for fail opening CSV.
robertbartel Nov 27, 2023
e1d22a6
Adjust new error message for fail opening CSV.
robertbartel Nov 27, 2023
bf4bd30
Include <cerrno> w/ use of errno for portability.
robertbartel Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions include/utilities/CSV_Reader.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,18 @@ class CSVReader
*/
inline std::vector<std::vector<std::string> > CSVReader::getData()
{
errno = 0;
std::ifstream file(fileName);

if(file.fail()){
/// \todo TODO: Return appropriate error
throw std::runtime_error("Error: Input file " + fileName + " does not exist.");
if (file.fail()) {
throw std::runtime_error(
errno == 0
? "Error: failure opening " + fileName
: "Errno " + std::to_string(errno) + " (" + strerror(errno) + ") opening " + fileName
);

/// \todo Potentially only output warning and fill array with sentinel values.
}
/// \todo Potentially only output warning and fill array with sentinel values.
}

std::vector<std::vector<std::string> > dataList;

Expand Down
Loading