Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor bmi adapters into their own library #672

Merged
merged 3 commits into from
Nov 7, 2023

Conversation

hellkite500
Copy link
Contributor

@hellkite500 hellkite500 commented Nov 7, 2023

[Short description explaining the high-level reason for the pull request]

Changes

  • Refactor the bmi adapter code into its own ngen_bmi library
  • Refactor test code/organization for bmi adapters

Testing

  1. All tests refactored and running locally

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Target Environment support

  • Linux
  • MacOS

@hellkite500
Copy link
Contributor Author

Ugh...looks like I'll have to a little more work on the build refactors (not sure why I didn't run into it locally, but I'll get this cleaned up soon)

src/bmi/CMakeLists.txt Outdated Show resolved Hide resolved
@hellkite500
Copy link
Contributor Author

Looks like the runners are happy now...If no other changes are needed, I'll rebase my last commit and get this ready to merge. If there are some additional changes anyone thinks are required, I'll clean up with those changes.

@hellkite500 hellkite500 merged commit bce7954 into NOAA-OWP:master Nov 7, 2023
17 of 19 checks passed
@hellkite500 hellkite500 deleted the bmi-adapter-refactor branch November 7, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants