Fix reproducibility issues for certain irregular layout when running in repro 64bit mode #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bensonr
approved these changes
Dec 2, 2024
laurenchilutti
approved these changes
Dec 2, 2024
lharris4
reviewed
Dec 2, 2024
| ust3(i) = ustar(i)**3. | ||
| wscale(i)=(ust3(i)+wfac*vk*wst3(i)*sfcfrac)**h1 | ||
| tem = gotvx(i,1)*sflux(i)*hpbl(i) | ||
| wscale(i)=(ustar(i)**3+wfac*vk*tem*sfcfrac)**h1 |
|
Great detective work @JosephMouallem @laurenchilutti . This extra effort is much appreciated. In the future, should we add a condition on new codes that constants are properly defined to avoid this problem in the future? Is this something that potentially a 'lint'-type source code checker could catch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SHiELD RTS cases fail to reproduce when using irregular PE layouts. The problem occurred exclusively in 64-bit repro mode, while 32-bit repro and both 32/64-bit debug modes were unaffected. This PR resolves the issue, ensuring reproducibility for scripts utilizing the TKE PBL scheme when compiled with a lower optimization level (AVX_LEVEL=-march=core-avx-i). Reproducibility has been verified for C48 tests on both C5 and C6.