Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and updates related to Noah-MP #52

Merged
merged 10 commits into from
Jul 1, 2024

Conversation

kaiyuan-cheng
Copy link
Contributor

@kaiyuan-cheng kaiyuan-cheng commented Jun 27, 2024

Description

A number of fixes, updates, and code clean-up related to Noah-MP:

  1. fix issue with iems = 2, together with updated surface emissivity initialization. Originally, the surface emissivity was 0.95 everywhere anytime over land and sea-ice. The fix gives realistic spatial and temporal distribution of surface emissivity.
    image

  2. fix wrong type of precipitation passed to Noah-MP. Specifically, this PR fixes that falling cloud ice was passed into Noah-MP as falling hail.

  3. fix the representation of mixing ratio. Correct conversion from modified specific humidity (vapor_mass/[dry_mass + vapor_mass]; used in the GFS physics) to mixing ratio.

  4. fix potential temperature calculation

  5. fix water table recharge, based on version 4.5 of the official Noah-MP repository

  6. update snow initialization, based on version 4.5 of the official Noah-MP repository

  7. fix the output of wilting point

cc: @spencerkclark and @lharris4

How Has This Been Tested?

Tested on Gaea with a C96 case. Restart run and layout change do not change the answer.

Checklist:

Please check all whether they apply or not

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@kaiyuan-cheng kaiyuan-cheng changed the title Fixes and updates related to Noah-mp Fixes and updates related to Noah-MP Jun 27, 2024
Copy link
Contributor

@lharris4 lharris4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks ok. Since it will change answers, could we have a couple of plots with this PR to summarize what is changed (such as your plots of emissivity you sent by Email)?

@kaiyuan-cheng
Copy link
Contributor Author

I think this looks ok. Since it will change answers, could we have a couple of plots with this PR to summarize what is changed (such as your plots of emissivity you sent by Email)?

I have added more details to the proposed fixes.

Copy link
Contributor

@lharris4 lharris4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this additional documentation. I think this is good now.

@lharris4 lharris4 merged commit ae954aa into NOAA-GFDL:main Jul 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants