-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes and updates related to Noah-MP #52
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks ok. Since it will change answers, could we have a couple of plots with this PR to summarize what is changed (such as your plots of emissivity you sent by Email)?
I have added more details to the proposed fixes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this additional documentation. I think this is good now.
Description
A number of fixes, updates, and code clean-up related to Noah-MP:
fix issue with iems = 2, together with updated surface emissivity initialization. Originally, the surface emissivity was 0.95 everywhere anytime over land and sea-ice. The fix gives realistic spatial and temporal distribution of surface emissivity.
fix wrong type of precipitation passed to Noah-MP. Specifically, this PR fixes that falling cloud ice was passed into Noah-MP as falling hail.
fix the representation of mixing ratio. Correct conversion from modified specific humidity (vapor_mass/[dry_mass + vapor_mass]; used in the GFS physics) to mixing ratio.
fix potential temperature calculation
fix water table recharge, based on version 4.5 of the official Noah-MP repository
update snow initialization, based on version 4.5 of the official Noah-MP repository
fix the output of wilting point
cc: @spencerkclark and @lharris4
How Has This Been Tested?
Tested on Gaea with a C96 case. Restart run and layout change do not change the answer.
Checklist:
Please check all whether they apply or not